introduce reduce with inout accumulator parameter#2611
Closed
kjaklinovic wants to merge 1 commit intoReactiveX:mainfrom
Closed
introduce reduce with inout accumulator parameter#2611kjaklinovic wants to merge 1 commit intoReactiveX:mainfrom
kjaklinovic wants to merge 1 commit intoReactiveX:mainfrom
Conversation
Author
|
Hi @freak4pc , are there any further actions I need do perform for this one ? I can't check the logs of the failing checks. |
Member
|
Cleaning up the repo and closing old PRs. If this is still something you're interested in pursuing, feel free to comment and we can re-open and discuss. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scanfunction has a variant in which it takes an input parameter as the first accumulator argument. I find that function more convenient since it requires a bit less code for the accumulator. I noticed that the same is not true forreduce, so I decided to introduce this behavior. I pretty much followed the same code style asscanhas. I did the same for tests too, for every ~second existing test forreduceI introduced the new variant of the operator.